Re: [PATCHES] WITH DELIMITERS in COPY - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] WITH DELIMITERS in COPY
Date
Msg-id 200204162349.g3GNnj527600@candle.pha.pa.us
Whole thread Raw
In response to Re: [PATCHES] WITH DELIMITERS in COPY  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Oh, I think we were talking at cross-purposes then.  What you're really
> unhappy about is that this uses a list of two-element sublists?  Yeah,
> I agree, that's a messy data structure; a list of DefElem would be
> perhaps cleaner.  Not sure if it matters all that much though, since the
> list only exists in the context of a few productions in gram.y.  Perhaps
> adding a couple of lines of documentation would be better than changing
> the code.

Yea, documenation and/or a list of DefElem would be nicer.  The problem
is that people are going to copy this in the future, so I may as well do
it right.  Can't take more than 20 minutes.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] WITH DELIMITERS in COPY
Next
From: Gavin Sherry
Date:
Subject: Re: [PATCHES] WITH DELIMITERS in COPY