Re: elog() patch - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: elog() patch
Date
Msg-id 200203040328.g243Stv15270@candle.pha.pa.us
Whole thread Raw
In response to elog() patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: elog() patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > However, with DEBUG symbol gone, or at least gone after 7.3, I don't see
> > a big need to add PG_ to the beginning of every elog() symbol.  Can I
> > get some votes on that?  DEBUG was our big culprit of conflict with
> > other interfaces, specifically Perl.
> 
> Wrong: ERROR is a problem too.  And if you think that INFO or WARNING
> or PANIC will not create new problems, you are a hopeless optimist.
> 
> We are already forcing renamings of a lot of elog symbols (eg, NOTICE
> and DEBUG), so we may as well go the extra step and actually solve the
> problem, rather than continue to ignore it.
> 
> BTW, I'd go with PGERROR etc, not PG_ERROR, just to save typing.

OK, unless someone else responds, we will go with PG* and
NOTICE->WARNING near 7.3 beta start when tree is quiet.  We will keep
old symbols around for 7.3 release.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: elog() patch
Next
From: Tom Lane
Date:
Subject: Re: elog() patch