Re: quotes in SET grammar - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: quotes in SET grammar
Date
Msg-id 200202261605.g1QG52d28096@candle.pha.pa.us
Whole thread Raw
In response to quotes in SET grammar  (Thomas Lockhart <thomas@fourpalms.org>)
List pgsql-hackers
Thomas Lockhart wrote:
> Christopher's patch to fix docs regarding single- and double-quotes in
> SET syntax got me looking at gram.y. It turns out that although we allow
> lists of double-quoted strings in SET, we do not allow lists of
> single-quoted strings (the latter should have been preferred afaik). And
> although we allow single-quoted strings in SET TIME ZONE, we do not
> allow double-quoted strings! So things seem inconsistant to me.
> 
> Possible cases look like
> 
>   SET TIME ZONE 'pst8pdt';
>   SET TIME ZONE "pst8pdt";
>   SET DATESTYLE = "US","ISO";
> 
> Is there any objection to allowing both single- and double-quoted
> strings in SET? Or should I remove the double-quoted variety altogether?
> I've got patches for the former, but am willing to consider either
> solution. afaik single-quoted strings would be sufficient to cover
> users' expectations, and all cases are extentions to SQL9x syntax, which
> only specifies SET TIME ZONE with a numeric offset. Comments?

I think only single quotes should be allowed.  These are strings.  The
double-quotes have such a different meaning in SQL that their use seems
confusing.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: mlw
Date:
Subject: Re: PostgreSQL 8.0 ??
Next
From: Tom Lane
Date:
Subject: Re: quotes in SET grammar