Re: postgresql.conf syntax - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: postgresql.conf syntax
Date
Msg-id 200201040550.g045oCf29015@candle.pha.pa.us
Whole thread Raw
In response to postgresql.conf syntax  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian wrote:
> Someone on IRC was confused by the contents of postgresql.conf:
>
>     #ifdef USE_ASSERT_CHECKING
>     #debug_assertions = true
>     #endif
>
> I have to say I was confused myself.  The #ifdef and #end are merely
> comments, while appears like that syntax is supported by PostgreSQL.  I
> think we should put just plain comments at the top of each section.
> Objections?

OK, I have replaced #ifdef with # requires.  Patch attached and applied.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
Index: src/backend/utils/misc/postgresql.conf.sample
===================================================================
RCS file: /cvsroot/pgsql/src/backend/utils/misc/postgresql.conf.sample,v
retrieving revision 1.27
diff -c -r1.27 postgresql.conf.sample
*** src/backend/utils/misc/postgresql.conf.sample    2001/12/17 19:09:01    1.27
--- src/backend/utils/misc/postgresql.conf.sample    2002/01/04 05:48:47
***************
*** 120,138 ****
  #debug_print_plan = false
  #debug_pretty_print = false

! #ifdef USE_ASSERT_CHECKING
  #debug_assertions = true
- #endif


  #
  #    Syslog
  #
! #ifdef ENABLE_SYSLOG
  #syslog = 0 # range 0-2
  #syslog_facility = 'LOCAL0'
  #syslog_ident = 'postgres'
- #endif


  #
--- 120,136 ----
  #debug_print_plan = false
  #debug_pretty_print = false

! # requires USE_ASSERT_CHECKING
  #debug_assertions = true


  #
  #    Syslog
  #
! # requires ENABLE_SYSLOG
  #syslog = 0 # range 0-2
  #syslog_facility = 'LOCAL0'
  #syslog_ident = 'postgres'


  #
***************
*** 142,150 ****
  #show_planner_stats = false
  #show_executor_stats = false
  #show_query_stats = false
! #ifdef BTREE_BUILD_STATS
  #show_btree_build_stats = false
- #endif


  #
--- 140,148 ----
  #show_planner_stats = false
  #show_executor_stats = false
  #show_query_stats = false
!
! # requires BTREE_BUILD_STATS
  #show_btree_build_stats = false


  #
***************
*** 161,174 ****
  #    Lock Tracing
  #
  #trace_notify = false
! #ifdef LOCK_DEBUG
  #trace_locks = false
  #trace_userlocks = false
  #trace_lwlocks = false
  #debug_deadlocks = false
  #trace_lock_oidmin = 16384
  #trace_lock_table = 0
- #endif


  #
--- 159,172 ----
  #    Lock Tracing
  #
  #trace_notify = false
!
! # requires LOCK_DEBUG
  #trace_locks = false
  #trace_userlocks = false
  #trace_lwlocks = false
  #debug_deadlocks = false
  #trace_lock_oidmin = 16384
  #trace_lock_table = 0


  #

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: PGSQL - FAQ 4.1
Next
From: "Christopher Kings-Lynne"
Date:
Subject: Re: Is there any performance penalty using --with-ssl?