Re: More problem with scripts - Mailing list pgsql-hackers

From Brent Verner
Subject Re: More problem with scripts
Date
Msg-id 20020103195146.GA68483@rcfile.org
Whole thread Raw
In response to Re: More problem with scripts  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: More problem with scripts
List pgsql-hackers
[2002-01-03 14:19] Bruce Momjian said:
| 
| Actually, we can just do:
| 
| >      *)
| >      dbname=$1
| >      [ "$#" -ne 1 ] && usage=1
| 
| Meaning if they have anything after the dbname, it is an error.  This
| catches flags _after_ the dbname.  Seems most of the script have this
| problem.  If people want it fixed, I can easily do it;  just give me to
| go-ahead.

+1
 I can't see a reason to /not/ fix something this simple for the 7.2 
release.  In general, I think it's best to fix things like this[1]
"on sight" as opposed to queueing them in TODO where they /might/ sit
untouched through another release cycle.

[1] meaning problems that require little effort to fix, and whose   solutions are /very/ localized.

cheers. brent

-- 
"Develop your talent, man, and leave the world something. Records are 
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing."  -- Duane Allman


pgsql-hackers by date:

Previous
From: Brent Verner
Date:
Subject: Re: More problem with scripts
Next
From: Bruce Momjian
Date:
Subject: Re: More problem with scripts