Re: The dbase conrtib doesn't compile - Mailing list pgsql-hackers

> In HEAD contrib/dbase:
>
> gcc -pipe -O2 -Wall -Wmissing-prototypes -Wmissing-declarations -I../../src/
> interf
> aces/libpq -I. -I../../src/include   -c -o dbf2pg.o dbf2pg.c
> dbf2pg.c:19: iconv.h: No such file or directory
> dbf2pg.c:38: syntax error before `iconv_d'
> dbf2pg.c:38: warning: type defaults to `int' in declaration of `iconv_d'
> dbf2pg.c:38: warning: data definition has no type or storage class
> dbf2pg.c: In function `convert_charset':
> dbf2pg.c:148: warning: implicit declaration of function `iconv'
> dbf2pg.c: In function `main':
> dbf2pg.c:789: warning: implicit declaration of function `iconv_open'
> dbf2pg.c:790: `iconv_t' undeclared (first use in this function)
> dbf2pg.c:790: (Each undeclared identifier is reported only once
> dbf2pg.c:790: for each function it appears in.)
> dbf2pg.c:810: warning: implicit declaration of function `iconv_close'
> gmake: *** [dbf2pg.o] Error 1

Yes, I am seeing the same failure here.  I knew there was a /contrib
module that needed iconv but I can't find it now.  I suppose this was
the one.

I see the old Makefile used iconv:

!       $(CC) $(CFLAGS) $(OBJS) $(libpq) $(LDFLAGS) $(LIBS) -liconv -o $@

but the overhaul of these Makefiles on 2001/09/06 removed it.  I am
applying the following patch to re-add it.  You will need libiconv for
it to link.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
Index: contrib/dbase/Makefile
===================================================================
RCS file: /cvsroot/pgsql/contrib/dbase/Makefile,v
retrieving revision 1.2
diff -c -r1.2 Makefile
*** contrib/dbase/Makefile    2001/09/06 10:49:29    1.2
--- contrib/dbase/Makefile    2001/12/21 04:10:17
***************
*** 7,13 ****
  PROGRAM = dbf2pg
  OBJS    = dbf.o dbf2pg.o endian.o
  PG_CPPFLAGS = -I$(libpq_srcdir)
! PG_LIBS = $(libpq)

  DOCS = README.dbf2pg
  MAN = dbf2pg.1            # XXX not implemented
--- 7,13 ----
  PROGRAM = dbf2pg
  OBJS    = dbf.o dbf2pg.o endian.o
  PG_CPPFLAGS = -I$(libpq_srcdir)
! PG_LIBS = $(libpq) -liconv

  DOCS = README.dbf2pg
  MAN = dbf2pg.1            # XXX not implemented
Index: contrib/dbase/README.dbf2pg
===================================================================
RCS file: /cvsroot/pgsql/contrib/dbase/README.dbf2pg,v
retrieving revision 1.1
diff -c -r1.1 README.dbf2pg
*** contrib/dbase/README.dbf2pg    2001/05/10 14:41:23    1.1
--- contrib/dbase/README.dbf2pg    2001/12/21 04:10:17
***************
*** 107,113 ****
  ENVIRONMENT
         This program is affected by the    environment-variables  as
         used  by  "PostgresSQL."   See  the documentation of Post-
!        gresSQL for more info.

  BUGS
         Fields larger than 8192 characters are not  supported  and
--- 107,113 ----
  ENVIRONMENT
         This program is affected by the    environment-variables  as
         used  by  "PostgresSQL."   See  the documentation of Post-
!        gresSQL for more info.  This program requires libiconv.

  BUGS
         Fields larger than 8192 characters are not  supported  and