Re: Open Items (was: RE: [HACKERS] Beta going well) - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Open Items (was: RE: [HACKERS] Beta going well)
Date
Msg-id 200111161832.fAGIWQM12721@candle.pha.pa.us
Whole thread Raw
List pgsql-hackers
> > The only problem I have now is that odbc/md5.h needs those unsigned
> > defines and it can't probe the results of queries by configure.  odbc
> > allows for stand-alone compile.
> 
> ODBC uses all kinds of other configure results, so it can use this one as
> well.  You only need to make sure you hard-code the test result for
> Windows somewhere.

Good point, Peter.  I had not seen that psqlodbc.h does conditionally
include pg_config.h.  I have added this test to md5.h:
/* Also defined in include/c.h */#if SIZEOF_UINT8 == 0typedef unsigned char uint8;    /* == 8 bits */typedef unsigned
shortuint16;  /* == 16 bits */typedef unsigned int uint32;    /* == 32 bits */#endif   /* SIZEOF_UINT8 == 0 */
 

In the case of WIN32, SIZEOF_UINT8 is not defined, so it should compare
equal to zero, and should include those defines, as needed.  It now
matches c.h.  Is that OK?

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: "Mike Rogers"
Date:
Subject: [PG MAIL LISTS] SEND OUT ALL????
Next
From: Bruce Momjian
Date:
Subject: Re: ecpg test problem