Re: ALTER TABLE RENAME fix - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: ALTER TABLE RENAME fix
Date
Msg-id 200111122026.fACKQLt22708@candle.pha.pa.us
Whole thread Raw
In response to Re: ALTER TABLE RENAME fix  (Brent Verner <brent@rcfile.org>)
List pgsql-patches
> On 12 Nov 2001 at 18:28 (+0100), Peter Eisentraut wrote:
> | Brent Verner writes:
> |
> | > These patches fix the problem where an
> | >
> | >   ALTER TABLE <table> RENAME <oldcolumn> TO <newcolumn>
> | >
> | > did not update the RI_ triggers if the oldcolumn was referenced in
> | > a RI constraint.
> |
> | Instead of trying to fix this, how about making the RI triggers not use
> | the column names in the first place.  (Instead they should use the oid of
> | the table and the attnums.)
>
> I agree with you.  Two things led me toward the current approach
> (modifying tgargs)
>   1) it would require fewer changes to get correct behavior, which
>      was important as late in beta as I started and
>   2) I had /some/ idea of how to get it done ;-)
>
> I'll begin to look at what would be required to do it the right
> way for 7.3.

Added to TODO:

    * Make triggers refer to columns by oid, not name

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Brent Verner
Date:
Subject: Re: ALTER TABLE RENAME fix
Next
From: Stephan Szabo
Date:
Subject: Re: ALTER TABLE RENAME fix