Re: Call for objections: revision of keyword classification - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Call for objections: revision of keyword classification
Date
Msg-id 200111091849.fA9InOP10807@candle.pha.pa.us
Whole thread Raw
In response to Re: Call for objections: revision of keyword classification  (Thomas Lockhart <lockhart@fourpalms.org>)
Responses Re: Call for objections: revision of keyword classification  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
> One possibility would be to put better comments into gram.y, and to back
> those comments up with a validation script that *could* generate
> keyword.c and other cross references. A bit more structure to the
> comments and code would enable that I think.

A validation script is a good intermediate idea, similar to our
duplicate_oids we have in include/catalog.  It would make sure
keywords.c was sorted, and make sure each keyword appeared somewhere in
lists of allowed function/column name productions.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Call for objections: revision of keyword classification
Next
From: Tom Lane
Date:
Subject: Re: Patch for Makefile race against current cvs