pgsql/src/interfaces/jdbc build.xml org/postgr ... - Mailing list pgsql-committers

From momjian@postgresql.org
Subject pgsql/src/interfaces/jdbc build.xml org/postgr ...
Date
Msg-id 200109230411.f8N4BE525579@postgresql.org
Whole thread Raw
List pgsql-committers
CVSROOT:    /cvsroot
Module name:    pgsql
Changes by:    momjian@postgresql.org    01/09/23 00:11:14

Modified files:
    src/interfaces/jdbc: build.xml
    src/interfaces/jdbc/org/postgresql/test: JDBC2Tests.java
    src/interfaces/jdbc/org/postgresql/test/jdbc2: ANTTest.java
                                                   BatchExecuteTest.java
                                                   BlobTest.java
                                                   ConnectionTest.java
                                                   DateTest.java
                                                   DriverTest.java
                                                   EncodingTest.java
                                                   JBuilderTest.java
                                                   MiscTest.java
                                                   TimeTest.java
                                                   TimestampTest.java

Log message:
    The attached patch is my first run-through of the JDBC test suite. A
    summary of changes:

    . removal of the tablename property from build.xml

    . addition of a dropTable method in JDBC2Tests and cleanups of many
    methods in the same

    . all tests now use non-deprecated assertXYZ methods instead of the
    deprecated assert method

    . failure in TimestampTest (testSetTimestamp) fixed. The failure is
    because testSetTimestamp was inserting a timestamp with hour 7 but
    checkTimeTest was expecting a timestamp with hour 8. AFAICS, there are
    no issues wrt daylight savings time and timestamps being pushed in and
    pulled out (but more explicit tests should be added in the future)

    . failure in TimeTest (testGetTime) fixed. Times to be inserted were
    interpreted in the localtime zone but checking was done with the
    assumption that the insertion was done in GMT.

    . formatting changes in a few of the source files (because I found
    it convenient to have consistent formatting while working on them). The
    formatting is consistent with the new format for java source files in
    PostgreSQL.

    Liam Stewart


pgsql-committers by date:

Previous
From: momjian@postgresql.org
Date:
Subject: pgsql/doc TODO
Next
From: momjian@postgresql.org
Date:
Subject: pgsql/doc TODO