Re: Patch for Improved Syntax Error Reporting - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Patch for Improved Syntax Error Reporting
Date
Msg-id 200109061630.f86GUmN00871@candle.pha.pa.us
Whole thread Raw
In response to Re: Patch for Improved Syntax Error Reporting  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Email added to TODO.detail.


> Dave Page <dpage@vale-housing.co.uk> writes:
> > Oh, I quite agree. I'm not adverse to updating my code, I just want to avoid
> > users getting misleading messages until I come up with those updates.
>
> Hmm ... if they were actively misleading then I'd share your concern.
>
> I guess what you're thinking is that the error offset reported by the
> backend won't correspond directly to what the user typed, and if the
> user tries to use the offset to manually count off characters, he may
> arrive at the wrong place?  Good point.  I'm not sure whether a message
> like
>
>     ERROR:  parser: parse error at or near 'frum';
>     POSITION: 42
>
> would be likely to encourage people to try that.  Thoughts?  (I do think
> this is a good argument for not embedding the position straight into the
> main error message though...)
>
> One possible compromise is to combine the straight character-offset
> approach with a simplistic context display:
>
>     ERROR:  parser: parse error at or near 'frum';
>     POSITION: 42  ... oid,relname FRUM ...
>
> The idea is to define the "POSITION" field as an integer offset possibly
> followed by whitespace and noise words.  An updated client would grab
> the offset, ignore the rest of the field, and do the right thing.  A
> not-updated client would display the entire message, and with any luck
> the user would read it correctly.
>
>             regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Patch for pl/tcl Tcl_ExternalToUtf and Tcl_UtfToExternal
Next
From: Rene Pijlman
Date:
Subject: Re: JDBC patch procedures (Re: Patch for jdbc2 ResultSet.java)