Bug #424: JDBC driver security issue. - Mailing list pgsql-bugs

From pgsql-bugs@postgresql.org
Subject Bug #424: JDBC driver security issue.
Date
Msg-id 200108240017.f7O0Hp842565@hub.org
Whole thread Raw
Responses Re: Bug #424: JDBC driver security issue.  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: Bug #424: JDBC driver security issue.  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-bugs
David Daney (David.Daney@avtrex.com) reports a bug with a severity of 3
The lower the number the more severe it is.

Short Description
JDBC driver security issue.

Long Description
The JDBC driver requires

   permission java.lang.RuntimePermission "shutdownHooks";

in the policy file in order to function.  However the driver does not protect the shutdown hooks call in an
AccessController.doPrivileged()call, so these permissions must be granted to all code not just the postgres JDBC
driver.


Sample Code
Here is a diff that fixes the problem.

*** ConnectionHook.java.orig    Mon Mar  5 01:17:43 2001
--- ConnectionHook.java    Thu Aug 23 16:51:49 2001
***************
*** 1,6 ****
--- 1,9 ----
  package org.postgresql.core;

  import java.sql.SQLException;
+ import java.security.AccessController;
+ import java.security.PrivilegedAction;
+
  import java.util.ArrayList;
  import java.util.Iterator;
  import org.postgresql.Connection;
***************
*** 51,57 ****
     */
    private ConnectionHook() {
      super();
!     Runtime.getRuntime().addShutdownHook(new Thread(this));
    }

    /**
--- 54,65 ----
     */
    private ConnectionHook() {
      super();
!     AccessController.doPrivileged(new PrivilegedAction() {
!           public Object run() {
!              Runtime.getRuntime().addShutdownHook(new Thread(ConnectionHook.this));
!              return null; // nothing to return
!           }
!        });
    }

    /**


No file was uploaded with this report

pgsql-bugs by date:

Previous
From: pgsql-bugs@postgresql.org
Date:
Subject: Bug #423: unable to do selects on certain fields in large tables
Next
From: Tom Lane
Date:
Subject: Re: memory leak while using vaccum