Re: PQsetdbLogin bug? - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: PQsetdbLogin bug?
Date
Msg-id 20010528133623S.t-ishii@sra.co.jp
Whole thread Raw
In response to Re: PQsetdbLogin bug?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Tatsuo Ishii <t-ishii@sra.co.jp> writes:
> > 2) check if the status of handle returned PQsetdbLogin is
> >    CONNECTION_BAD closePGconn. if so, do not call pqPuts (and
> >    pqFlush)
> 
> I like this approach.  The other way, you'd have to be sure that all
> failure paths close the socket before returning; even if you get it
> right today, somebody will break it again in future.  The sending of
> the final 'X' is really quite optional anyhow, so I'd say it's fine
> not to do it when there's any question about whether it's safe.

done.
--
Tatsuo Ishii


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: /contrib/earthdistance/Makefile patch
Next
From: Zeugswetter Andreas SB
Date:
Subject: AW: GiST index on data types that require compression