Re: patch for BETWEEN [ASYMMETRIC|SYMMETRIC] - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: patch for BETWEEN [ASYMMETRIC|SYMMETRIC]
Date
Msg-id 200105072211.f47MB9W04148@candle.pha.pa.us
Whole thread Raw
In response to Re: patch for BETWEEN [ASYMMETRIC|SYMMETRIC]  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
OK, patch rejected.


> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Can someone comment on where we left this?
>
> The grammar patch is incorrect/incomplete as given (no keywords.c
> entries, no additions to the TokenId list), unless you quoted only
> part of it.
>
> More generally, I hate to see us yet again doing a quick shortcut that
> loses information.  BETWEEN really ought to be a 3-operand function or
> special expression node type, so that it (a) can be reverse-listed
> sensibly, and (b) doesn't result in multiple evaluations of its inputs.
>
>             regards, tom lane
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: [GENERAL] Strange notices, should I worry?
Next
From: Bruce Momjian
Date:
Subject: Re: ODBC cleanup