Re: WAL and commit_delay - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: WAL and commit_delay
Date
Msg-id 200102171905.OAA28285@candle.pha.pa.us
Whole thread Raw
In response to Re: WAL and commit_delay  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> Actually ... take a close look at the code.  The delay is done in
> xact.c between XLogInsert(commitrecord) and XLogFlush().  As near
> as I can tell, both the write() and the fsync() will happen in
> XLogFlush().  This means the delay is just plain broken: placed
> there, it cannot do anything except waste time.

I see.  :-(

> Another thing I am wondering about is why we're not using fdatasync(),
> where available, instead of fsync().  The whole point of preallocating
> the WAL files is to make fdatasync safe, no?

I don't have fdatasync() here.  How does it compare to fsync().

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: WAL and commit_delay
Next
From: Bruce Momjian
Date:
Subject: Re: WAL and commit_delay