> Good catch, Joe! This bug has probably been there since the beginning
> of time. It's evidently got no serious consequences (since in reality,
> OID uniqueness is not assumed for this table), but it ought to be fixed.
> A quick-hack solution would be to zero out the tuple's OID before each
> heap_insert, but really AppendAttributeTuples should be rewritten to
> construct each tuple independently in the first place.
>
> A quick 'glimpse' shows no other uses of heap_modifytuple except to
> update an existing tuple, so evidently no one was foolish enough to
> copy this technique.
>
> I recommend putting this on the TODO for 7.2. We can't fix it now
> unless we want to force an initdb.
Added to TODO:
* Prevent pg_attribute from having duplicate oids for indexes
-- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610)
853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill,
Pennsylvania19026
