Re: compute_query_id and pg_stat_statements - Mailing list pgsql-hackers

From Tom Lane
Subject Re: compute_query_id and pg_stat_statements
Date
Msg-id 2000204.1619371023@sss.pgh.pa.us
Whole thread Raw
In response to Re: compute_query_id and pg_stat_statements  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: compute_query_id and pg_stat_statements  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
Julien Rouhaud <rjuju123@gmail.com> writes:
> On Sun, Apr 25, 2021 at 11:39:55AM -0400, Tom Lane wrote:
>> I agree repeated warnings would be bad news.  I was wondering if we could
>> arrange a single warning at the time pg_stat_statements is preloaded into
>> the postmaster.  In this way, if you tried to use a configuration file
>> that used to work, you'd hopefully get some notice about why it no longer
>> does what you want.  Also, if you are preloading pg_stat_statements, it
>> seems reasonable to assume that you'd like the global value of the flag
>> to be "on", even if there are use-cases for transiently disabling it.

> What about people who wants to use pg_stat_statements but are not ok with our
> query_id heuristics and use a third-party plugin for that?

They're still going to want the GUC set to something other than "off",
no?  In any case it's just a one-time log message, so it's not likely
to be *that* annoying.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Yura Sokolov
Date:
Subject: Re: Use simplehash.h instead of dynahash in SMgr
Next
From: Julien Rouhaud
Date:
Subject: Re: compute_query_id and pg_stat_statements