Re: Changes to pg_dump/psql following collation "C" in the catalog - Mailing list pgsql-hackers

From Daniel Verite
Subject Re: Changes to pg_dump/psql following collation "C" in the catalog
Date
Msg-id 1f34d7f9-deba-4ddb-b805-e9b608b0defd@manitou-mail.org
Whole thread Raw
In response to Re: Changes to pg_dump/psql following collation "C" in the catalog  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Changes to pg_dump/psql following collation "C" in the catalog  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
    Tom Lane wrote:

> Hm, if that's as much as we have to touch, I think there's a good
> argument for squeezing it into v12 rather than waiting.  The point
> here is mostly to avoid a behavior change from pre-v12

Yes. I was mentioning the next CF because ISTM that nowadays
non-committers are expected to file patches in there, committers
picking up patches both in the current and next CF based on
their evaluation of priorities.
But if you plan to process this one shortly, a CF entry is probably
superfluous.

> Just looking at the patch, I wonder whether it doesn't need some
> server-version checks.  At the very least this would break with
> pre-9.1 servers, which lack COLLATE altogether.

PFA a new version adding the clause for only 12 and up, since the
previous versions are not concerned, and as you mention, really old
versions would fail otherwise.


Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite

Attachment

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [PATCH v20] GSSAPI encryption support
Next
From: Andrew Dunstan
Date:
Subject: Re: Re: A separate table level option to control compression