Re: [HACKERS] Useless code in ExecInitModifyTable - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: [HACKERS] Useless code in ExecInitModifyTable
Date
Msg-id 1ed12418-ce9a-471d-dbec-e85b32d71f47@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] Useless code in ExecInitModifyTable  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] Useless code in ExecInitModifyTable  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
List pgsql-hackers
On 2017/06/21 23:52, Robert Haas wrote:

> You're right that there is a comment missing from the function header,
> but it's not too hard to figure out what it should be.  Just consult
> the definition of ModifyTable itself:
> 
>          /* RT indexes of non-leaf tables in a partition tree */
>          List       *partitioned_rels;

I agree on that point, but I think it's better to add the missing 
comment for the create_modifytable_path argument, as proposed in [1].

Best regards,
Etsuro Fujita

[1] 
https://www.postgresql.org/message-id/e87c4a6d-23d7-5e7c-e8db-44ed418eb5d1%40lab.ntt.co.jp




pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: [HACKERS] Fix a typo in partition.c
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Get stuck when dropping a subscription duringsynchronizing table