Postgres Pro
Downloads
Home   >   mailing lists

Re: Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration
Date
Msg-id 1dba85f6-6bdd-0cd8-1287-d1c208bf0421@2ndquadrant.com
Whole thread Raw
In response to Re: Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Range checks of pg_test_fsync --secs-per-test and pg_test_timing --duration  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On 2020-09-24 09:12, Michael Paquier wrote:
> On Wed, Sep 23, 2020 at 08:11:59AM +0200, Peter Eisentraut wrote:
>> This patch mixes up unsigned int and uint32 in random ways.  The variable is
>> uint32, but the format is %u and the max constant is UINT_MAX.
>>
>> I think just use unsigned int as the variable type.  There is no need to use
>> the bit-exact types.  Note that the argument of alarm() is of type unsigned
>> int.
> 
> Makes sense, thanks.

looks good to me

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Katsuragi Yuta
Date:
Subject: Re: [PATCH] Add features to pg_stat_statements
Next
From: Ashutosh Sharma
Date:
Subject: Re: Logical replication from PG v13 and below to PG v14 (devel version) is not working.