On Wed, 2025-07-09 at 12:05 +0530, Amit Kapila wrote:
> On Tue, Jul 8, 2025 at 10:23 PM Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> >
> > On Sat, 2025-07-05 at 12:13 -0400, Tom Lane wrote:
> > > Oh, wait a second. I just noticed that this variable is new in v18.
> > > So there won't be a compatibility issue as long as we change it in
> > > v18 too. So changing it to a base of seconds seems sufficient,
> > > and more in line with existing practice:
> > >
> > > Using 'ms' seems clearly overkill, but there's precedent for
> > > timeouts measured in seconds.
> >
> > Here is a patch that changes the unit to seconds, like Fujii Masao's
> > patch upthread. In addition, it removes the now unnecessary injection
> > point for the TAP test and tries to improve the documentation to
> > address my complaints.
> >
>
> +# Wait a bit for the replication slots to become invalid
> +$node->safe_psql('postgres', "SELECT pg_sleep(2)");
>
> Is it a good idea to add 2s to 'make check-world' for one particular test?
That is debatable. I thought that adding two seconds would be worth the
advantage of removing the injection point that only fakes the timeout.
We'd get better test coverage.
But if the people who run the regression tests dozens of times every day
object to the two seconds, I won't insist on this part of the patch.
Yours,
Laurenz Albe
