Re: Column Filtering in Logical Replication - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: Column Filtering in Logical Replication
Date
Msg-id 1c8ee74f-d393-42c7-b83d-dad991717a1a@www.fastmail.com
Whole thread Raw
In response to Re: Column Filtering in Logical Replication  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Mon, Sep 6, 2021, at 2:51 PM, Alvaro Herrera wrote:
I pushed the clerical part of this -- namely the addition of
PublicationTable node and PublicationRelInfo struct.  I attach the part
of your v4 patch that I didn't include.  It contains a couple of small
corrections, but I didn't do anything invasive (such as pgindent)
because that would perhaps cause you too much merge pain.
While updating the row filter patch [1] (because it also uses these
structures), I noticed that you use PublicationRelInfo as a type name instead
of PublicationRelationInfo. I choose the latter because there is already a data
structure named PublicationRelInfo (pg_dump.h). It is a client-side data
structure but I doesn't seem a good practice to duplicate data structure names
over the same code base.



--
Euler Taveira

pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: parallelizing the archiver
Next
From: Tom Lane
Date:
Subject: Re: Allow escape in application_name (was: [postgres_fdw] add local pid to fallback_application_name)