Postgres Pro
Downloads
Home   >   mailing lists

Re: Postgres_fdw join pushdown - wrong results with whole-row reference - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Postgres_fdw join pushdown - wrong results with whole-row reference
Date
Msg-id 1c4bcedf-1f89-e0b8-0cbf-8811a0858037@lab.ntt.co.jp
Whole thread Raw
In response to Re: Postgres_fdw join pushdown - wrong results with whole-row reference  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Postgres_fdw join pushdown - wrong results with whole-row reference  (Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>)
List pgsql-hackers
Tree view 
On 2016/06/25 4:14, Robert Haas wrote:
> Committed that way.

Thanks for taking care of this!

I found another bug in error handling of whole-row references in join
pushdown; conversion_error_callback fails to take into account that
get_relid_attribute_name(Oid relid, AttrNumber attnum) can't handle
whole-row references (ie, attnum=0), in which case that would cause
cache lookup errors.  Attached is a small patch to address this issue.

Best regards,
Etsuro Fujita
Attachment

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Cleanup in contrib/postgres_fdw/deparse.c
Next
From: Ashutosh Bapat
Date:
Subject: Re: Postgres_fdw join pushdown - wrong results with whole-row reference