On 3/16/17 11:56, Alvaro Herrera wrote:
> Michael Paquier wrote:
>
>> What are you using as CFLAGS? As both typenames should be normally
>> set, what about initializing those fields with NULL and add an
>> assertion like the attached?
>
> Actually, my compiler was right -- this was an ancient bug I introduced
> in 9.5 (commit a61fd533), and this new warning was my compiler being a
> bit smarter now for some reason. The problem is we were trying to
> extract String value from a TypeName node, which obviously doesn't work
> very well.
>
> I pushed a real fix, not just a compiler-silencer, along with a few
> lines in object_address.sql to make sure it works properly. Maybe we
> need a few more tests cases for other parts of pg_get_object_address.
>
> Pushed fix, backpatched to 9.5.
I am now seeing the warnings that Michael was reporting *after* your
commit in 9.5 and 9.6.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
