Re: Align memory context level numbering in pg_log_backend_memory_contexts() - Mailing list pgsql-hackers

On 2025/04/18 6:11, David Rowley wrote:
> On Fri, 18 Apr 2025 at 00:25, Rahila Syed <rahilasyed90@gmail.com> wrote:
>> Regarding v2 patch,
>> -                       int                     level = 0;
>>
>> Retaining the level variable will enhance the code readability, IMO.
> 
> When I read that, I suspected it might have been leftover from a
> refactor during the development that was forgotten about. There'd be
> thousands of places in our code base that you could make the
> readability argument for, including the max_level and max_children
> parameters at the same call-site. But those didn't get the same
> treatment.
> 
> I've now pushed the latest patch. Thanks for the reviews.

Shouldn't the example output of pg_log_backend_memory_contexts() in
the documentation also be updated to use 1-based numbering for consistency?
Patch attached.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION