Re: [HACKERS] Out of date comment in predicate.c - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] Out of date comment in predicate.c
Date
Msg-id 1a0efd3e-97b7-707e-d851-54cad0118999@2ndquadrant.com
Whole thread Raw
In response to [HACKERS] Out of date comment in predicate.c  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: [HACKERS] Out of date comment in predicate.c
List pgsql-hackers
On 6/27/17 01:21, Thomas Munro wrote:
> Commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f got rid of
> FirstPredicateLockMgrLock, but it's still referred to in a comment in
> predicate.c where the locking protocol is documented.  I think it's
> probably best to use the name of the macro that's usually used to
> access the lock array in the code.  Please see attached.

Does this apply equally to PredicateLockHashPartitionLock() and
PredicateLockHashPartitionLockByIndex()?  Should the comment mention or
imply both?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Get stuck when dropping a subscription duringsynchronizing table
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h