Re: Reducing connection overhead in pg_upgrade compat check phase - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Reducing connection overhead in pg_upgrade compat check phase
Date
Msg-id 1FE28680-333E-433C-9809-95662037B0AA@yesql.se
Whole thread Raw
In response to Re: Reducing connection overhead in pg_upgrade compat check phase  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: Reducing connection overhead in pg_upgrade compat check phase
List pgsql-hackers
> On 11 Jul 2023, at 01:09, Nathan Bossart <nathandbossart@gmail.com> wrote:
> On Mon, Jul 10, 2023 at 04:43:23PM +0200, Daniel Gustafsson wrote:

>>> +static int    n_data_types_usage_checks = 7;
>>>
>>> Can we determine this programmatically so that folks don't need to remember
>>> to update it?
>>
>> Fair point, I've added a counter loop to the beginning of the check function to
>> calculate it.
>
> +    /* Gather number of checks to perform */
> +    while (tmp->status != NULL)
> +        n_data_types_usage_checks++;
>
> I think we need to tmp++ somewhere here.

Yuk, yes, will fix when caffeinated. Thanks.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: doc: improve the restriction description of using indexes on REPLICA IDENTITY FULL table.
Next
From: Jacob Champion
Date:
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER