Bug fix for cache lookup failure for statistic_ext type - Mailing list pgsql-hackers

From Mark Dilger
Subject Bug fix for cache lookup failure for statistic_ext type
Date
Msg-id 1F238937-7CC2-4703-A1B1-6DC225B8978A@enterprisedb.com
Whole thread Raw
Responses Re: Bug fix for cache lookup failure for statistic_ext type  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
List pgsql-hackers
Hackers,

You can easily get a cache lookup failure by changing the regression tests as included in this small patch.  The
failurelooks thus: 

+COMMENT ON STATISTICS ab1_a_b_stats IS 'new comment';
+CREATE ROLE temp_role;
+SET SESSION AUTHORIZATION temp_role;
+COMMENT ON STATISTICS ab1_a_b_stats IS 'changed comment';
+ERROR:  cache lookup failed for type 27447
+DROP STATISTICS ab1_a_b_stats;
+ERROR:  cache lookup failed for type 27447
+ALTER STATISTICS ab1_a_b_stats RENAME TO ab1_a_b_stats_new;
+ERROR:  must be owner of statistics object ab1_a_b_stats
+RESET SESSION AUTHORIZATION;
+DROP ROLE temp_role;

I believe this case simply has not had any test coverage, as I don't see any way the current code would ever work.  It
treatsthe Oid of the statistics object as a type, which it is not. 




—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




Attachment

pgsql-hackers by date:

Previous
From: Paul Martinez
Date:
Subject: Re: [PATCH] Partial foreign key updates in referential integrity triggers
Next
From: Tom Lane
Date:
Subject: Another regexp performance improvement: skip useless paren-captures