Re: [HACKERS] Add some const decorations to prototypes - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: [HACKERS] Add some const decorations to prototypes
Date
Msg-id 1ED3A51F-E29E-4499-8E04-0F0E895CF275@gmail.com
Whole thread Raw
In response to [HACKERS] Add some const decorations to prototypes  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
> On Oct 31, 2017, at 7:46 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>
> Here is a patch that adds const decorations to many char * arguments in
> functions.  It should have no impact otherwise; there are very few code
> changes caused by it.  Some functions have a strtol()-like behavior
> where they take in a const char * and return a pointer into that as
> another argument.  In those cases, I added a cast or two.
>
> Generally, I find these const decorations useful as easy function
> documentation.

+1

I submitted something similar a while back and got into a back and forth
discussion with Tom about it.  Anyone interested could take a look at

https://www.postgresql.org/message-id/ACF3A030-E3D5-4E68-B744-184E11DE68F3%40gmail.com




--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: David Christensen
Date:
Subject: Re: [HACKERS] [PATCH] Add two-arg for of current_setting(NAME,FALLBACK)
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] [PATCH] Pageinspect - add functions on GIN and GiSTindexes from gevel