> On 4 Oct 2018, at 09:59, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Oct 03, 2018 at 12:09:54PM +1300, Thomas Munro wrote:
>> It looks like you missed another case that needs tolerance for late
>> signal delivery on Windows:
>>
>> +select pg_cancel_backend(pg_backend_pid());
>>
>> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.15263
>
> Looking at 0001, why are the declarations needed in patch 0002 part of
> 0001 (see signalfuncs.h)? I think that something like instead the
> attached is enough for this part. Daniel, could you confirm?
Yes, you are correct, the signalfuncs.h includes in 0001 are a rebase error
from when I renamed the file. They are not present in the v15 patch but got
introduced in v16 when I clearly wasn’t caffeinated enough to rebase.
cheers ./daniel
