Re: Refactor MD5 implementations and switch to EVP for OpenSSL - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Refactor MD5 implementations and switch to EVP for OpenSSL
Date
Msg-id 1D2A172C-19DA-46F3-9A8D-444CE58294E4@yesql.se
Whole thread Raw
In response to Re: Refactor MD5 implementations and switch to EVP for OpenSSL  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Refactor MD5 implementations and switch to EVP for OpenSSL
List pgsql-hackers
> On 9 Dec 2020, at 06:47, Michael Paquier <michael@paquier.xyz> wrote:

> In short, this seems rather committable to me.

Agreed, this version of the patch looks good to me.  I've looked over the
attributions for the code movement and it seems to match now, and all tests
pass etc. +1 on going ahead with this version.

The tiniest level of nitpicking would be that md5.h doesn't have the 
/* PG_MD5_H */ comment on the #endif line (and it's even tinier since it's
not even the fault of this patch - I just happened to notice when looking
at that file).

cheers ./daniel



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently
Next
From: Bharath Rupireddy
Date:
Subject: Re: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently