Re: Remove obsolate comments from 047_checkpoint_physical_slot - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Remove obsolate comments from 047_checkpoint_physical_slot
Date
Msg-id 1B51369C-EF99-4D97-A201-66F000640B94@yesql.se
Whole thread Raw
In response to RE: Remove obsolate comments from 047_checkpoint_physical_slot  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses Re: Remove obsolate comments from 047_checkpoint_physical_slot
List pgsql-hackers
> On 25 Sep 2025, at 09:23, Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> wrote:
>
> Dear hackers,
>
>> While reviewing others, I found $SUBJECT.
>
> I found another cleanup point related with this. In CreateCheckPoint():
>
> ```
> #ifdef USE_INJECTION_POINTS
> INJECTION_POINT("checkpoint-before-old-wal-removal");
> #endif
> ```
>
> Here USE_INJECTION_POINTS check is not needed. If the feature is disabled,
> the macro function would be ((void) name). IIUC, we are using the macro if if-branch
> exists.

+1, that's not needed (and not used elsewhere in the code either).

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Remove obsolate comments from 047_checkpoint_physical_slot
Next
From: Chao Li
Date:
Subject: Re: Add support for specifying tables in pg_createsubscriber.