Re: Remove obsolate comments from 047_checkpoint_physical_slot - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove obsolate comments from 047_checkpoint_physical_slot
Date
Msg-id aNT2bbtG8vyEo5_K@paquier.xyz
Whole thread Raw
In response to Re: Remove obsolate comments from 047_checkpoint_physical_slot  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Remove obsolate comments from 047_checkpoint_physical_slot
List pgsql-hackers
On Thu, Sep 25, 2025 at 09:32:40AM +0200, Daniel Gustafsson wrote:
> On 25 Sep 2025, at 09:23, Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com> wrote:
>> Here USE_INJECTION_POINTS check is not needed. If the feature is disabled,
>> the macro function would be ((void) name). IIUC, we are using the macro if if-branch
>> exists.
>
> +1, that's not needed (and not used elsewhere in the code either).

Yeah, let's remove that.  Simplification in the backend code is the
whole point of the double definition of the INJECTION_POINT() macro in
injection_point.h.

And the comments of the test 047 are indeed not required anymore.
Good catch.

If you want to go ahead and clean up all that, Daniel, please feel
free.  If not, I'm OK to pull the trigger on this one.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
Next
From: Chao Li
Date:
Subject: Re: Fix incorrect function comment of stringToNodeInternal