RE: Remove obsolate comments from 047_checkpoint_physical_slot - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: Remove obsolate comments from 047_checkpoint_physical_slot
Date
Msg-id OSCPR01MB14966C8015DEB05ABEF2CE077F51FA@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Remove obsolate comments from 047_checkpoint_physical_slot  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
Responses Re: Remove obsolate comments from 047_checkpoint_physical_slot
List pgsql-hackers
Dear hackers,

> While reviewing others, I found $SUBJECT.

I found another cleanup point related with this. In CreateCheckPoint():

```
#ifdef USE_INJECTION_POINTS
    INJECTION_POINT("checkpoint-before-old-wal-removal");
#endif
```

Here USE_INJECTION_POINTS check is not needed. If the feature is disabled,
the macro function would be ((void) name). IIUC, we are using the macro if if-branch
exists.

E.g., another injection point "create-restart-point" does not have the #ifdef part.

Best regards,
Hayato Kuroda
FUJITSU LIMITED




pgsql-hackers by date:

Previous
From: Yugo Nagata
Date:
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench
Next
From: Daniel Gustafsson
Date:
Subject: Re: Remove obsolate comments from 047_checkpoint_physical_slot