Re: pgsql: Fix pg_type.typlen for newly-revived line type. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix pg_type.typlen for newly-revived line type.
Date
Msg-id 19999.1399316447@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix pg_type.typlen for newly-revived line type.  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: pgsql: Fix pg_type.typlen for newly-revived line type.  (Bruce Momjian <bruce@momjian.us>)
List pgsql-committers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Tom Lane wrote:
>> Note that if the line type had been in use in the field, this would
>> break pg_upgrade'ability of databases containing line values; but
>> it seems unlikely that there are any (they'd have had to be compiled
>> with -DENABLE_LINE_TYPE).

> Should we add a test to pg_upgrade --check mode?

I doubt it's worth it.  Anybody who was enabling the old code is pretty
well screwed no matter what.  They can't upgrade with a plain pg_dump
either, since the I/O format is different.

What we do need, probably, is a warning about the incompatibility in the
release notes.

            regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix possible cache invalidation failure in ReceiveSharedInvalidM
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Replace SYSTEMQUOTEs with Windows-specific wrapper functions.