Re: [HACKERS] Re: [PATCHES] COMMENT ON patch - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Re: [PATCHES] COMMENT ON patch
Date
Msg-id 199910260452.AAA20092@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Re: [PATCHES] COMMENT ON patch  (Mike Mascari <mascarim@yahoo.com>)
List pgsql-hackers
> Hmm, this is where I'm getting the oid's:
> 
> DATABASE -- pg_database
> INDEX -- pg_class
> RULE -- pg_rewrite
> SEQUENCE -- pg_class
> TABLE -- pg_class
> TYPE -- pg_type
> VIEW -- pg_class
> COLUMN -- pg_attribute
> AGGREGATE -- pg_aggregate
> FUNCTION -- pg_proc
> OPERATOR -- pg_operator
> TRIGGER -- pg_trigger
> 
> So in the example you gave above, you could put a comment
> on each of the two functions which compose the operator
> and a command on the operator itself.
> 
> I still need to write the SGML and change pg_dump to

Please update the sgml and psqlHelp.c files I have already modified for
you.  I thought you didn't want to do it, so I did it.


> generate COMMENT ON statements, and also regression tests,
> but the functionality should be complete. Just glancing
> over the Win32 ODBC driver, it appears that SQLTables() and
> SQLColumns() is not currently fetching the associated
> description from pg_description for the REMARKS parameter
> to the call. Perhaps this could be changed? 

Hmm.  Never heard of that.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Re: [PATCHES] COMMENT ON patch
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Re: [PATCHES] COMMENT ON patch