Re: [HACKERS] It would be nice if this could be fixed... - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] It would be nice if this could be fixed...
Date
Msg-id 199905070305.XAA09049@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] It would be nice if this could be fixed...  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> I think it'd be a good idea to try to centralize this knowledge so that
> there are fewer places to change to add a new node type.  For example,
> a routine that wants to examine all the Var nodes in a tree should be
> able to look something like this:
> 
>     if (IsA(node, Var))
>     {
>         process var node;
>     }
>     else
>         standard_tree_walker(node, myself, ...);
> 
> rather than having another copy of a bunch of error-prone boilerplate.

That is an interesting idea.  The current code clearly needs cleanup and
is error-prone.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Hashjoin status report
Next
From: Chris Bitmead
Date:
Subject: pg_dump problem?