Re: New patch (was: tough bug) - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: New patch (was: tough bug)
Date
Msg-id 199902021920.OAA07138@candle.pha.pa.us
Whole thread Raw
In response to New patch (was: tough bug)  (Goran Thyni <goran@kirra.net>)
List pgsql-hackers
Applied.


[Charset iso-8859-1 unsupported, filtering to ASCII...]
> 
> OK I found it,
> I search in the planner for the '\xFF' appending.
> Finally I found in MakeIndexable() in gram.y
> 
> Attach a patch which removes the "<=" test in USE_LOCALE,
> might make some queries a bit slower for us "locale-heads",
> BUT correct result is more important.
> 
>     regards,
> -- 
> -----------------
> G_ran Thyni
> This is Penguin Country. On a quiet night you can hear Windows NT
> reboot!

> diff -c pgsql/src/backend/parser/gram.y.orig pgsql/src/backend/parser/gram.y
> *** pgsql/src/backend/parser/gram.y.orig    Tue Jan 26 07:02:32 1999
> --- pgsql/src/backend/parser/gram.y    Mon Feb  1 21:16:56 1999
> ***************
> *** 5249,5259 ****
> --- 5249,5265 ----
>                   least->val.val.str = match_least;
>                   most->val.type = T_String;
>                   most->val.val.str = match_most;
> + #ifdef USE_LOCALE
> +                 result = makeA_Expr(AND, NULL,
> +                         makeA_Expr(OP, "~", lexpr, rexpr),
> +                         makeA_Expr(OP, ">=", lexpr, (Node *)least));
> + #else
>                   result = makeA_Expr(AND, NULL,
>                           makeA_Expr(OP, "~", lexpr, rexpr),
>                           makeA_Expr(AND, NULL,
>                               makeA_Expr(OP, ">=", lexpr, (Node *)least),
>                               makeA_Expr(OP, "<=", lexpr, (Node *)most)));
> + #endif
>               }
>           }
>       }
> ***************
> *** 5296,5306 ****
> --- 5302,5318 ----
>                   least->val.val.str = match_least;
>                   most->val.type = T_String;
>                   most->val.val.str = match_most;
> + #ifdef USE_LOCALE
> +                 result = makeA_Expr(AND, NULL,
> +                         makeA_Expr(OP, "~~", lexpr, rexpr),
> +                         makeA_Expr(OP, ">=", lexpr, (Node *)least));
> + #else
>                   result = makeA_Expr(AND, NULL,
>                           makeA_Expr(OP, "~~", lexpr, rexpr),
>                           makeA_Expr(AND, NULL,
>                               makeA_Expr(OP, ">=", lexpr, (Node *)least),
>                               makeA_Expr(OP, "<=", lexpr, (Node *)most)));
> + #endif
>               }
>           }
>       }
> 
> 
> 
> 
> 
> 


--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: 6.5 beta and ORDER BY patch
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Optimizer speed and GEQO (was: nested loops in joins)