pg_attribute typo?? - Mailing list pgsql-hackers

From Keith Parks
Subject pg_attribute typo??
Date
Msg-id 199808261927.UAA03548@mtcc.demon.co.uk
Whole thread Raw
Responses Re: pg_attribute typo??  (Bruce Momjian <maillist@candle.pha.pa.us>)
List pgsql-hackers
Bruce,

Just noticed the following warning when compiling for the
umpteenth time ;-)


gcc -I../../../include -I../../../backend   -O2  -Wall -Wmissing-prototypes -g
-I../..   -c relcache.c -o relcache.o
relcache.c:110: warning: multi-character character constant
relcache.c:110: warning: overflow in implicit constant conversion

Upon investigation I find what should be a 'd' was a 'd '

Here's a patch.

Keith.

*** ./src/include/catalog/pg_attribute.h.orig   Wed Aug 26 19:19:35 1998
--- ./src/include/catalog/pg_attribute.h        Wed Aug 26 19:20:26 1998
***************
*** 317,323 ****
   */
  #define Schema_pg_attribute \
  { 1249, {"attrelid"},   26, 0,        4,      1, 0, -1, -1, '\001', '\0', 'i',
'\0', '\0' }, \
! { 1249, {"attname"},    19, 0, NAMEDATALEN,   2, 0, -1, -1, '\0', '\0', 'd ',
'\0', '\0' }, \
  { 1249, {"atttypid"},   26, 0,        4,      3, 0, -1, -1, '\001', '\0', 'i',
'\0', '\0' }, \
  { 1249, {"attdisbursion"}, 700, 0,    4,      4, 0, -1, -1, '\0', '\0', 'i',
'\0', '\0' }, \
  { 1249, {"attlen"},             21, 0,        2,      5, 0, -1, -1, '\001',
'\0', 's', '\0', '\0' }, \
--- 317,323 ----
   */
  #define Schema_pg_attribute \
  { 1249, {"attrelid"},   26, 0,        4,      1, 0, -1, -1, '\001', '\0', 'i',
'\0', '\0' }, \
! { 1249, {"attname"},    19, 0, NAMEDATALEN,   2, 0, -1, -1, '\0', '\0', 'd',
'\0', '\0' }, \
  { 1249, {"atttypid"},   26, 0,        4,      3, 0, -1, -1, '\001', '\0', 'i',
'\0', '\0' }, \
  { 1249, {"attdisbursion"}, 700, 0,    4,      4, 0, -1, -1, '\0', '\0', 'i',
'\0', '\0' }, \
  { 1249, {"attlen"},             21, 0,        2,      5, 0, -1, -1, '\001',
'\0', 's', '\0', '\0' }, \


pgsql-hackers by date:

Previous
From: David Hartwig
Date:
Subject: Re: [HACKERS] Regression test status (was type coersion)
Next
From: Tom Ivar Helbekkmo
Date:
Subject: Re: [HACKERS] vacuum problem