Re: [BUGS] About failed compile on BSDI 2.1 - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [BUGS] About failed compile on BSDI 2.1
Date
Msg-id 199806211638.MAA01413@candle.pha.pa.us
Whole thread Raw
List pgsql-hackers
>
> On Sat, 20 Jun 1998, Bruce Momjian wrote:
>
> > >
> > > On Fri, 19 Jun 1998, Bruce Momjian wrote:
> > >
> > > > >
> > > > > Hi,
> > > > >
> > > > > I just send out a mail that I got a compile-error ona bsdi 2.1 machine. I
> > > > > wanted to let you know I fixed it.
> > > > >
> > > > > The problem was that sys/un.h was included twice (directly from pqcomm.c
> > > > > and indirectly through libpq/auth.h and down). On my system, this
> > > > > include-file (sys/un.h) is not guarded by #ifndef's. I removed the
> > > > > explicit #include in pqcomm.c and things compiled.
> > > >
> > > > Oh.  good
> > >
> > > Same thing happened in interfaces/libpq/fe-connect.c, I also fixed that
> > > locally. Should this be fixed upstream also?
> >
> > Sure.  Send it over and I will check it against 3.1.
>
> Well, my fix was very simple, and might not be that portable. I just
> commented out the lines that said '#include <sys/un.h>', since this file
> was also included from libpq/auth.h. I think it's save to just remove
> these lines from pqcomm.c and fe-connect.c.

OK, removed include in both files.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

pgsql-hackers by date:

Previous
From: Keith Parks
Date:
Subject: Re: [HACKERS] s_lock.h problem on S/Linux
Next
From: dg@illustra.com (David Gould)
Date:
Subject: Re: [HACKERS] s_lock.h problem on S/Linux