Re: [HACKERS] Open 6.3.1 issues - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] Open 6.3.1 issues
Date
Msg-id 199804052000.QAA20536@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Open 6.3.1 issues  ("Thomas G. Lockhart" <lockhart@alumni.caltech.edu>)
Responses Re: [HACKERS] Open 6.3.1 issues
List pgsql-hackers
>
> > > > >       indexes not used that were used in 6.2(fixed)
> > > > >       memory leak in backend when run on simple queries(fixed)
> > > > >       negative sign causing problems in various areas
> > > > >       configure assert checking is reversed
> > > > >       UNION crashes on ORDER BY or DISTINCT
> > I would think we are safer by releasing a new diff.  The char2-16
> > changes are the only ones I know of that should not have been applied
> > (by me!), so we can back them out.  Just seems it is too easy to miss
> > some part of the patch.
>
> Well, we have the other side of the problem to worry about too: that
> with changes in the source tree, there may be unanticipated interactions
> with other patches when we are really trying to fix only 5 specific
> problems.
>
> I would like to do a test with specific patches on a clean v6.3.1
> installation, and then we can compare the patches from my test with
> patches from the CVS extraction. I'll isolate my "negative sign" fixes
> (which I haven't yet committed to the source tree, but which I think
> just need a reversion of scan.l/scan.c to the v6.3 release).
>
> Can you (re)send me the patches for these others? I still have the
> "memory leak" patches, but can't remember who posted the "index" and
> "UNION" patches (were they all yours Bruce?? Probably gone from my mail
> anyway).

Vadim did the index one, and I think I have a copy.  The UNION was
several patches by the time I was happy with it, so I would have to do a
diff on just the files I know I changed.

None of the current bugs are from changes made between 6.3 and 6.3.1
except the negative patch, so I can't see us adding more problems.

The regression test did not show these problems either, so I have little
confidence that they will find new bugs we may be introducing.  If we go
with the current tree, we can have people who use cvsup keep testing the
snapshot until we are happy with it.

We will probably need Marc to make this decision.  It can be argued
either way.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

pgsql-hackers by date:

Previous
From: "Thomas G. Lockhart"
Date:
Subject: Re: [QUESTIONS] money * money?
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Open 6.3.1 issues