Re: [HACKERS] How to...? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [HACKERS] How to...?
Date
Msg-id 199803091514.KAA01864@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] How to...?  (Andrew Martin <martin@biochemistry.ucl.ac.uk>)
List pgsql-hackers
> I do think it would be a good idea if the pg_dumpall from the new release
> looked for these now-reserved column names and warned the user. You could
> then at least know where problems will occur. In upgrades from d/b versions
> which support ALTER TABLE xxx RENAME COLUMN yyy TO zzz, you would actually
> be able to do something about it before re-dumping...

pg_dumpall is just a shell script.  You would have to do it in pg_dump.
I hesistate to meddle with that code unless I have good reason for it.
We could have a separate function that scans pg_attribute looking for
bad column names.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

pgsql-hackers by date:

Previous
From: jwieck@debis.com (Jan Wieck)
Date:
Subject: Re: [HACKERS] create trigger question
Next
From: "Maurice Gittens"
Date:
Subject: Re: [HACKERS] newoid in invapi.c