Re: [HACKERS] SunOS patches - Mailing list pgsql-hackers

From t-ishii@sra.co.jp
Subject Re: [HACKERS] SunOS patches
Date
Msg-id 199803020321.MAA04401@srapc451.sra.co.jp
Whole thread Raw
In response to Re: [HACKERS] SunOS patches  (The Hermit Hacker <scrappy@hub.org>)
List pgsql-hackers
>> ----------------------------------------------------------------------
>> *** backend/libpq/pqcomm.c.orig    Fri Feb 27 14:07:52 1998
>> --- backend/libpq/pqcomm.c    Fri Feb 27 14:08:50 1998
>> ***************
>> *** 564,571 ****
>>    * Shutdown routine for backend connection
>>    * If a Unix socket is used for communication, explicitly close it.
>>    */
>> ! static void
>> ! do_unlink()
>>   {
>>       if (sock_path[0])
>>           unlink(sock_path);
>> --- 564,571 ----
>>    * Shutdown routine for backend connection
>>    * If a Unix socket is used for communication, explicitly close it.
>>    */
>> ! void
>> ! StreamDoUnlink()
>
>
>    What breaks by renaming this function?? :(

Nothing. do_unlink() is called only from line 648 and the line was
deleted by my patches.
Just removing "static" from the declaration of do_unlink might be ok.
However function name "do_unlink" would be too general IMHO.
--
Tatsuo Ishii
t-ishii@sra.co.jp

pgsql-hackers by date:

Previous
From: The Hermit Hacker
Date:
Subject: Re: [HACKERS] SunOS patches
Next
From: "Thomas G. Lockhart"
Date:
Subject: Re: [HACKERS] SunOS patches