Re: [HACKERS] Current 6.3 issues - Mailing list pgsql-hackers

From Michael Meskes
Subject Re: [HACKERS] Current 6.3 issues
Date
Msg-id 199802271027.LAA11737@gauss.topsystem.de
Whole thread Raw
List pgsql-hackers
t-ishii@sra.co.jp writes:
> >Does it help to add #include <sys/types.h> to pgc.l? I'm not sure which
> >file I should include to be correct.
>
> Yes.

Is already in CVS.

> BTW, line 32 of preproc/main.c has:
>
>     char        c,
>
> 'char c' should be 'int c' I think. Otherwise
>
>     while ((c = getopt(argc, argv, "vdo:")) != EOF)
>
> will not work on some platforms.

Thanks. Changed in my source tree. Will be submitted later.

> Another problem is SunOS does not have getopt(). Possible solutions
> might be:
>
> a. steal getopt(3) source from FreeBSD
> b. rewrite main.c so that it does not use getopt().
>
> I would prefer (a) since it would be easier:-) How do you think?

Ehem, how do we solve this in the backend? It does use getopt, too.

Michael

--
Dr. Michael Meskes, Project-Manager    | topsystem Systemhaus GmbH
meskes@topsystem.de                    | Europark A2, Adenauerstr. 20
meskes@debian.org                      | 52146 Wuerselen
Go SF49ers! Go Rhein Fire!             | Tel: (+49) 2405/4670-44
Use Debian GNU/Linux!                  | Fax: (+49) 2405/4670-10

pgsql-hackers by date:

Previous
From: Michael Meskes
Date:
Subject: Re: [HACKERS] Snapshot 26Feb98 - another minor showstopper
Next
From: "Vadim B. Mikheev"
Date:
Subject: Re: [HACKERS] common area