Re: pgsql: Straighten include order in guc-file.l - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Straighten include order in guc-file.l
Date
Msg-id 1974929.1667481540@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Straighten include order in guc-file.l  (John Naylor <john.naylor@enterprisedb.com>)
List pgsql-committers
John Naylor <john.naylor@enterprisedb.com> writes:
> flaviventris fails on the pg_resetwal test with "initdb: error: invalid
> locale settings; check LANG and LC_* environment variables", and
> idiacanthus fails to start the server in another tap test. But if this
> commit were at fault, surely they would fail more spectacularly?

Given the shortage of other failures, I'd write these off as noise
... unless they reproduce in future runs.  But even then, it's
very hard to blame it on this commit.

            regards, tom lane



pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: Re: pgsql: Straighten include order in guc-file.l
Next
From: Tom Lane
Date:
Subject: pgsql: Add casts to simplehash.h to silence C++ warnings.