Re: -Wformat-signedness - Mailing list pgsql-hackers

From Tom Lane
Subject Re: -Wformat-signedness
Date
Msg-id 1974847.1604935524@sss.pgh.pa.us
Whole thread Raw
In response to Re: -Wformat-signedness  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: -Wformat-signedness  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> 1. enums are unsigned by default in gcc, so all those internal error 
> messages "unrecognized blah kind: %d" need to be changed to %u.

Do we have reason to think that that is true in every C compiler?
My own preference for this would be to leave the messages as-is
and add explicit "(int)" casts to the arguments.  There are some
fraction of these that are like that already.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Disable WAL logging to speed up data loading
Next
From: Dmitry Shulga
Date:
Subject: Re: Reduce the time required for a database recovery from archive.