Re: [BUGS] BUG #1118: Misleading Commit message - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [BUGS] BUG #1118: Misleading Commit message
Date
Msg-id 19720.1089488535@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUGS] BUG #1118: Misleading Commit message  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [BUGS] BUG #1118: Misleading Commit message  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> MOVE, FETCH, EXECUTE ...

> Ah, yes, I remember we changed EXECUTE recently to return the tag of
> what we executed.  How do we modify MOVE/FETCH tags?  I can't remember.

I was just looking to see what cases ProcessUtility allowed to change
the tag.  I think that what the code does is just to append the row
count, which you could argue isn't "changing the tag".  But really,
is returning "UPDATE 0" vs "UPDATE 1" any different conceptually from
what we are talking about here?  It's still using the tag to pass back
info about what the command actually did.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [BUGS] BUG #1118: Misleading Commit message
Next
From: Josh Berkus
Date:
Subject: Re: Nested Transactions, Abort All