Re: Some optimisations for numeric division - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Some optimisations for numeric division
Date
Msg-id 1967295.1645813833@sss.pgh.pa.us
Whole thread Raw
In response to Re: Some optimisations for numeric division  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: Some optimisations for numeric division  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> And another update following feedback from the cfbot.

This patchset LGTM.  On my machine there doesn't seem to be any
measurable performance change for the numeric regression test,
but numeric_big gets about 15% faster.

The only additional thought I have, based on your comments about
0001, is that maybe in mul_var we should declare var1digit as
being NumericDigit not int.  I tried that here and didn't see
any material change in the generated assembly code (using gcc
8.5.0), so you're right that modern gcc doesn't need any help
there; but I wonder if it could help on other compiler versions.

I'll mark this RFC.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: [PATCH] Add reloption for views to enable RLS
Next
From: Julien Rouhaud
Date:
Subject: Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)