Neil Conway <neilc@samurai.com> writes:
> BTW, how do people feel about the function names:
> SPI_cursor_open_with_options
> SPI_scroll_cursor_fetch
> SPI_scroll_cursor_move
I dislike the SPI_cursor_open_with_options API on the grounds that it
lets people break things (CURSOR_OPT_HOLD for instance isn't likely
to do anything good) and it doesn't actually provide any functionality
that wasn't there before (the existing code already sets OPT_SCROLL
if possible). I'd suggest losing that one entirely and just adding
the FetchDirection-as-substitute-for-"forward" entry points.
As for names, maybe
SPI_cursor_fetch_direction
SPI_cursor_move_direction
?
regards, tom lane
