Re: pg_control is missing a field for LOBLKSIZE - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_control is missing a field for LOBLKSIZE
Date
Msg-id 19478.1403046736@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_control is missing a field for LOBLKSIZE  (Bruce Momjian <bruce@momjian.us>)
Responses Re: pg_control is missing a field for LOBLKSIZE
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> On Tue, Jun 17, 2014 at 03:55:02PM -0400, Alvaro Herrera wrote:
>> Can't you compare it to the historic default value?  I mean, add an
>> assumption that people thus far has never tweaked it.

> Well, if they did tweak it, then they would be unable to use pg_upgrade
> because it would complain about a mismatch if they actually matched the
> old and new servers.

What about comparing to the symbolic value LOBLKSIZE?  This would make
pg_upgrade assume that the old installation had been tweaked the same
as in its own build.  This ends up being the same as what you said,
ie, effectively no comparison ... but it might be less complicated to
code/understand.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Atomics hardware support table & supported architectures
Next
From: Andrew Dunstan
Date:
Subject: comparison operators